-
Notifications
You must be signed in to change notification settings - Fork 548
Remove a broken YouTube link #1295
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Looks like Professor Reichenbach removed them from YouTube since they were being monetized without his consent. I found the first one in the series via the Wayback Machine (no ads). It's probably worth keeping. I found it quite helpful. |
I don't see the dataflow ones on his homepage yet. I'll try reaching out to him. |
Oh, I didn't know the Wayback Machine can play video content, TIL :)
Thanks! Then I'll wait for their answer and update the link following that. |
@JohnTitor Can we update the link in the meantime? |
4305be4
to
e6b5aa4
Compare
Sure, updated the link with a note. |
I think we are waiting on an answer from Professor Reichenbach, right? |
I've updated the link as @ecstatic-morse suggested, I think it's good to show it for now, until we get a response. |
@JohnTitor but what kind of response are we asking for?. I guess if they have deleted the video, we may not want to share it using webarchive unless they do consent us to do so?. |
They have a concern about YouTube Ads and it's unrelated if we use the Wayback Machine, no? But if you worry about it, I'm fine to remove it either, I just updated the link as @ecstatic-morse suggested and I don't have a strong preference here. |
I was just wondering what were you checking with them and if we are allowed to post this url at all. But if we do, let's merge this in. |
I see, feel free to approve and merge this if you're fine with it :) |
Just in case, as I see this is blocked on me or on someone else's review. I'm fine with someone merging this. Thinking in a practical way, I'd like to have a link to the video in the guide. I was just concerned that if the professor tried to remove the video, maybe there was a reason for that, that we could not be honoring by re-linking it. Maybe it was just because they didn't want to have it on YouTube, and they are fine with us linking it in other way or something. I wonder if we should and can check with them. |
@ecstatic-morse Do you have any response from them? |
I've sent an email to Professor Reichenbach, and they said that these videos are currently unavailable but they introduced some alternative videos and textbook:
At a glance, these are good lectures but I'm not an expert and couldn't determine which ones we should link to, @ecstatic-morse do these work for you? |
e6b5aa4
to
4f07566
Compare
They seem busy, for now, I updated the wording and added links to this PR and the above comment. @spastorino are you okay with this? |
Update books ## reference 6 commits in 8e36971959ff238b5aa2575fbc7a2e09e1313e82..b74825d8f88b685e239ade00f00de68ba4cd63d4 2022-05-09 17:20:59 -0700 to 2022-05-20 14:30:30 -0700 - Inline assembly: Clarify references to quoted regs (rust-lang/reference#1191) - Add tile registers to inline-assembly documentation (rust-lang/reference#1220) - Upper bound on hashes in raw string literals (rust-lang/reference#1180) - Remove footnote on warning about lifetime shadowing labels. - Makes explanation for Spans in "Procedural Macros" clearer (rust-lang/reference#1219) - Update "Match Expressions" to remove 'cold' (rust-lang/reference#1216) ## book 18 commits in d9415b7cbfcb4b24062683f429bd0ff535396362..b4dd5f00b87190ad5ef42cbc2a88a783c6ae57ef 2022-05-09 09:10:44 -0400 to 2022-05-24 21:37:06 -0400 - Snapshot of appendices for nostarch - Update rust-analyzer URLs and make links less repetitive - Correct byte string literal type. Fixes rust-lang/book#2631. - Fix verb agreement. Fixes rust-lang/book#3176 - Propagate ch19 edits to src - Edits to chapter 19 from nostarch - Propagate ch18 edits to src - Edits to ch18 from nostarch - Propagate tech review edits to src ch5 - Responses to chapter 5 tech review - Ch5 after tech review - Merge branch 'ch7-edits' - fix: mdBook authors - Propagating ch17 edits to src - Edits from nostarch for ch17 - Fix rust-lang/book#3152 - Wrong character used - & is not valid inside image alt text - Merge branch 'ch20' ## rust-by-example 2 commits in e9f93cfcf410bc092c9107b8a41a82f144c761f2..2ed26865e8c29ef939dc913a97bd321cadd72a9a 2022-05-08 18:24:06 -0300 to 2022-05-18 17:23:47 -0300 - Rework cpuid asm example. (rust-lang/rust-by-example#1542) - chore: better description for eprint macro (rust-lang/rust-by-example#1541) ## rustc-dev-guide 11 commits in 0c02acd..554c00e 2022-05-10 09:45:31 -0300 to 2022-05-24 17:15:35 -0700 - Cleanup rustdoc-internals - Fix some wording on the "Incremental Compilation In Detail" page - Exclude `tomlee.co` from link-checking (rust-lang/rustc-dev-guide#1356) - Add note about patching dependencies and warnings. (rust-lang/rustc-dev-guide#1354) - make sentence more simple (rust-lang/rustc-dev-guide#1353) - Update some links and docs (rust-lang/rustc-dev-guide#1340) - Replace a broken YouTube link (rust-lang/rustc-dev-guide#1295) - Edit the "Compiler Source Code" chapter (rust-lang/rustc-dev-guide#1307) - Add docs for logging of queries. (rust-lang/rustc-dev-guide#1350) - Fix configuration names for vscode/r-a (rust-lang/rustc-dev-guide#1352) - Update docs for deprecated attribute (rust-lang/rustc-dev-guide#1338)
This just removes the broken link and suggestion (for now).
cc @ecstatic-morse Do you have any other alternative? I've found https://www.youtube.com/watch?v=Lr4cMmaJHrg, but I'm not sure if it's what you want to show.
Fixes #1283