-
Notifications
You must be signed in to change notification settings - Fork 549
Updates prereqs to build LLVM from source for C++17. #1448
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
do these minimums apply to older llvm versions, which we support |
Good point! LLVM upgraded on August 6 which was very recent. Rust's fork of LLVM is still using C++14 so the old compilers would still be viable. |
the text could be changed to link to pre-reqs pages of the supported llvm versions, which can be older than the fork |
I edited the text point to the recent LLVM 14 release documentation and added a date check comment. Does this work? |
it does, thanks |
I assume you meant LLVM 13 |
Yes, oops my comment was wrong. The docs match regardless but I put 13 since it counts as one of the "last few" releases. |
it looks like the oldest one supported by nightly rust-lang/rust#100460 |
With the recent upgrade to C++17 in LLVM, this increases the minimum requirements for building LLVM from source. Matches those at https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library