Skip to content

Updates prereqs to build LLVM from source for C++17. #1448

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Aug 27, 2022

Conversation

red1bluelost
Copy link
Contributor

With the recent upgrade to C++17 in LLVM, this increases the minimum requirements for building LLVM from source. Matches those at https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library

@tshepang
Copy link
Member

tshepang commented Aug 27, 2022

do these minimums apply to older llvm versions, which we support

@red1bluelost
Copy link
Contributor Author

Good point! LLVM upgraded on August 6 which was very recent. Rust's fork of LLVM is still using C++14 so the old compilers would still be viable.
Maybe this PR can just be blocked until Rust updates the fork to the C++17 LLVM.

@tshepang
Copy link
Member

tshepang commented Aug 27, 2022

the text could be changed to link to pre-reqs pages of the supported llvm versions, which can be older than the fork

@red1bluelost
Copy link
Contributor Author

I edited the text point to the recent LLVM 14 release documentation and added a date check comment. Does this work?

@tshepang
Copy link
Member

it does, thanks

@tshepang tshepang merged commit daca468 into rust-lang:master Aug 27, 2022
@tshepang
Copy link
Member

tshepang commented Aug 27, 2022

I edited the text point to the recent LLVM 14 release documentation and added a date check comment.

I assume you meant LLVM 13

@red1bluelost
Copy link
Contributor Author

Yes, oops my comment was wrong. The docs match regardless but I put 13 since it counts as one of the "last few" releases.

@tshepang
Copy link
Member

it looks like the oldest one supported by nightly rust-lang/rust#100460

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants