Skip to content

Try to avoid confusion in how-to-build-and-run.md #1712

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 5 commits into from

Conversation

sslime336
Copy link
Contributor

This pr is the follower of #1710, which didn't finish it's job perfectly.

@sslime336 sslime336 closed this Jul 1, 2023
@jyn514
Copy link
Member

jyn514 commented Jul 1, 2023

@sslime336 this needs to be rebased over master - see https://rustc-dev-guide.rust-lang.org/git.html#advanced-rebasing for instructions. You'll want to drop all except the last commit ("Try to avoid confusion").

@sslime336
Copy link
Contributor Author

yes, I'm sorry I did not handle this well. I will handle this sooner.

@sslime336 sslime336 deleted the pr-finetune branch July 1, 2023 05:30
@sslime336
Copy link
Contributor Author

sslime336 commented Jul 1, 2023

@jyn514 Okey, here's new pr #1713 (hope this time it could be allright :P )
Sorry for making the workflow so messy.

@jyn514
Copy link
Member

jyn514 commented Jul 1, 2023

that's ok! thank you for fixing it :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants