Skip to content

[suggested.md] remove deprecated changelog-seen from shell.nix #1805

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Oct 10, 2023

I noticed the following warning

WARNING: The use of `changelog-seen` is deprecated. Please refer to `change-id` option in `config.example.toml` instead.

It would be nice to also resolve this warning

WARNING: The `change-id` is missing in the `config.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations.
note: to silence this warning, add `change-id = 115898` at the top of `config.toml`

but I can't think of a sensible way to include the change-id in shell.nix

I noticed the following warning
```
WARNING: The use of `changelog-seen` is deprecated. Please refer to `change-id` option in `config.example.toml` instead.
```

It would be nice to also resolve this warning
```
WARNING: The `change-id` is missing in the `config.toml`. This means that you will not be able to track the major changes made to the bootstrap configurations.
note: to silence this warning, add `change-id = 115898` at the top of `config.toml`
```
but I can't think of a sensible way to include the `change-id` in `shell.nix`
@eopb
Copy link
Contributor Author

eopb commented Oct 10, 2023

The change that replaced changelog-seen with change-id was introduced in rust-lang/rust#115898

@eopb
Copy link
Contributor Author

eopb commented Oct 10, 2023

Looking again at change-id, it does not look like it's expected to change often. Closing in favour of #1806

@eopb eopb closed this Oct 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant