Skip to content

Update incrcomp-debugging.md #1905

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2,284 commits into
base: master
Choose a base branch
from
Open

Conversation

Tbkhi
Copy link
Contributor

@Tbkhi Tbkhi commented Feb 25, 2024

Minor formatting updates.

langston-barrett and others added 30 commits March 16, 2023 18:40
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
"Getting Started" is already *very* long; this shrinks it a bit, and
puts similar info closer together.
This is advanced info that most contributors won't need to know; and for
experienced contributors, it means the info is at the top of the page
instead of needing to scroll.
There was a lot of information duplicated between the two, and it wasn't
clear which one to look. This commit changes `contributing.md` to be
strictly for contribution procedures, and moves "what should I work on"
sections to "Getting Started".

This also consolidates the links in `about-this-guide.md` rather than
spreading them between about-this-guide, getting-started, and
contributing.

I suggest using https://rustc-dev-guide.org/git.html#moving-large-sections-of-code to review this commit.
This is already covered in detail on Forge: https://forge.rust-lang.org/infra/toolstate.html
and linked in the previous paragraph.
@Tbkhi
Copy link
Contributor Author

Tbkhi commented Mar 5, 2024

Is TypeckTables still a part of the compiler?

https://doc.rust-lang.org/nightly/nightly-rustc/index.html?search=TypeckTables

src\queries\incremental-compilation-debugging.md
21:#[rustc_then_this_would_need(TypeckTables)] //~ ERROR OK
27:> If this (`foo`) is changed, then this (i.e. `bar`)'s `TypeckTables` would need to be changed.
35:#[rustc_then_this_would_need(TypeckTables)] //~ ERROR no path
40:> If `foo` is changed, then `baz`'s `TypeckTables` does not need to be changed.
78:RUST_DEP_GRAPH_FILTER='-> TypeckTables'
81:would select the predecessors of all `TypeckTables` nodes. Usually though you
82:want the `TypeckTables` node for some particular `fn`, so you might write:
85:RUST_DEP_GRAPH_FILTER='-> TypeckTables & bar'
88:This will select only the predecessors of `TypeckTables` nodes for functions
95:RUST_DEP_GRAPH_FILTER='Hir & foo -> TypeckTables & bar'
99:`TypeckTables(bar)`, from which you can (hopefully) see the source
125:Collect(bar) -> TypeckTables(bar)

@Tbkhi
Copy link
Contributor Author

Tbkhi commented Mar 5, 2024

CC: @spastorino

@jieyouxu jieyouxu added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Oct 8, 2024
@jieyouxu jieyouxu added A-contributor-onboarding Area: contributor on-boarding advice (e.g. for new contributors) T-compiler Relevant to compiler team A-incr-comp Area: incremental compilation A-devex Area: contributor developer experience WG-incr-comp Working group: incremental compilation labels Nov 4, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Jan 5, 2025

Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new master):

git fetch origin --all
git checkout <pr-branch>
git rebase --onto origin/master origin/master-old
git push --force-with-lease

More context can be found here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-contributor-onboarding Area: contributor on-boarding advice (e.g. for new contributors) A-devex Area: contributor developer experience A-incr-comp Area: incremental compilation S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content T-compiler Relevant to compiler team WG-incr-comp Working group: incremental compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.