Skip to content

Explain rustc_on_unimplemented #484

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2019
Merged

Explain rustc_on_unimplemented #484

merged 1 commit into from
Oct 27, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Oct 27, 2019

Extracted from the unstable book since it needs to be removed from there.
Doing this as part of rust-lang/rust#65794.

mark-i-m
mark-i-m approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mark-i-m mark-i-m merged commit 6dc2f38 into rust-lang:master Oct 27, 2019
@Centril Centril deleted the patch-1 branch October 27, 2019 20:26
jens1o
jens1o reviewed Oct 28, 2019
View reviewed changes
src/diagnostics.md
5 | for foo in "" {}
| ^^ `&str` is not an iterator
|
= note: call `.chars()` or `.bytes() on `&str`
Copy link

@jens1o jens1o Oct 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing ` after .bytes() :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jens1o jens1o jens1o left review comments

@mark-i-m mark-i-m mark-i-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Centril @mark-i-m @jens1o