Skip to content

Update .gitattributes #560

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2020
Merged

Update .gitattributes #560

merged 1 commit into from
Jan 14, 2020

Conversation

jethrogb
Copy link
Contributor

JohnTitor
JohnTitor reviewed Jan 14, 2020
View reviewed changes
.gitattributes
Comment on lines +6 to +7
*.jpg binary
*.ico binary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance, it seems this repository doesn't contain any JPEG or ICO files. Where do we need them or am I missing something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah they're not needed. I was just being exhaustive

mark-i-m
mark-i-m approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mark-i-m mark-i-m merged commit cf6447a into rust-lang:master Jan 14, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@JohnTitor JohnTitor JohnTitor left review comments

@mark-i-m mark-i-m mark-i-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jethrogb @mark-i-m @JohnTitor