Add some guidelines on diagnostics. #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Who? Me?! <mark-i-m@users.noreply.github.com> Co-authored-by: Chris Simpkins <git.simpkins@gmail.com>
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 29, 2020
…omatsakis Remove rustc-ux-guidelines This is now in the rustc-dev-guide: * rust-lang/rustc-dev-guide#716 * rust-lang/rustc-dev-guide#717 This is a public page, but it was not linked to anywhere, so I think it is safe to remove. Google searches don't show it being used anywhere.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a start on adding some guidelines for diagnostics. I would love to see more input from those who actually work on diagnostics, but I figure this might help get the ball rolling.
This is sourced from several places (RFCs, comments, rustc-ux-guidelines), along with my own editorializing.
cc #14