Skip to content

Add info about StringReader for #50 #72

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 9, 2018

Conversation

vishalsodani
Copy link
Contributor

No description provided.

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would it be possible to add a bit more information? How does it help with lexing?

@mark-i-m mark-i-m mentioned this pull request Mar 5, 2018
15 tasks
@vishalsodani
Copy link
Contributor Author

@mark-i-m I don't have much understanding how the compiler works. I found this walkthrough. Should I add this line

This is the interface which consumes the raw source input and converts it to a series of Tokens & Spans in a TokenStream.

@mark-i-m
Copy link
Member

mark-i-m commented Mar 8, 2018

@vishalsodani I think that looks good. Perhaps we could modify it as such:

This is the lexer used during parsing. It consumes characters from the raw source code being compiled and produces a series of tokens for use by the rest of the parser.

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mark-i-m mark-i-m merged commit 86c5f6c into rust-lang:master Mar 9, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants