-
Notifications
You must be signed in to change notification settings - Fork 547
Add prerequisite page #723
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some thoughts:
- I'd mention this chapter in somewhere of "How to Build and Run the Compiler"
- I'd also have a link to rust-lang/rust README since it should be up-to-date than here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @skade! This is definitely good content to have!
This comment has been minimized.
This comment has been minimized.
a974445
to
bb3a6cd
Compare
I don't understand the current CI failure... |
Works for me locally. Not sure what's going on in CI.
You can reproduce by adding github to the ignore list:
|
96fec7f
to
46e2397
Compare
46e2397
to
071c59f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think CI should finally pass 🤞
Thanks @skade!
Fixes #722
Currently only includes instructions for Windows, I didn't have a Linux machine available.
Taken from @yoshuawuyts instructions.