Name rustbuild instead of saying 'the bootstrap binary'
#808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Separated out from #807 |
|
I think we should wait to land this until we've renamed it upstream. |
|
Is there a particular PR on rust-lang/rust that this is blocked on? |
|
Not that I'm aware of. @Mark-Simulacrum are you sure it makes sense to rename the whole directory? In my mind 'rustbuild' is just the rust portion while 'bootstrap' is both python and rust put together. |
|
I've never separated the two, personally, but I also don't care much either way. |
camelid
reviewed
Oct 4, 2020
|
What's the status of this? |
|
I don't think this is a useful change; there's no point in adding new terminology if it's not going to be used consistently. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Mark-Simulacrum - is this reasonable? It's consistent with the
A-rustbuildtag on rust-lang/rust.