Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

More Clippy lint groups including pedantic #51

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

allan2
Copy link
Contributor

@allan2 allan2 commented Sep 11, 2024

Five lints corrected:

  • doc_markdown from pedantic (partial, see commit message)
  • cast_lossless from pedantic
  • use_self from nursery
  • too_long_first_doc_paragraph from style
  • cargo_common_metadata from cargo

Pedantic, nursery, and cargo group rules are added.

All lints are passing.

@allan2 allan2 changed the title Fix Clippy pedantic lints More Clippy lint groups including pedantic Sep 11, 2024
Copy link
Member

@WaffleLapkin WaffleLapkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cast_lossless and cargo_common_metadata fixes are a nice touch. everything else however doesn't look like an improvement to me.

src/lib.rs Outdated Show resolved Hide resolved
Co-authored-by: Joe ST <joe@fbstj.net>
@allan2
Copy link
Contributor Author

allan2 commented Sep 12, 2024

I could remove the nursery group if maintainers prefer, as it is an experimental group.

use_self lint is still in nursery because of false positives, not for style reasons.

@allan2
Copy link
Contributor Author

allan2 commented Sep 17, 2024

I've just kept the pedantic and cargo lint groups now. This is in line with rust-lang/cargo-bisect-rustc and rust-lang/rustc-perf.

@allan2 allan2 requested a review from WaffleLapkin October 11, 2024 12:11
@WaffleLapkin
Copy link
Member

I did not change my opinions since #51 (review)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants