Skip to content

Added support for testing the backend with abi-cafe #710

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FractalFir
Copy link
Contributor

I added a new command(abi-test) that runs the abi-cafe test suite, comparing the ABI implemented by the LLVM version of Rustc, and the GCC version of rustc.

Additionally, as a base sanity check, the command will also compare the implementation of the C abi in cg_gcc and in the system's C compiler.

Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@bjorn3
Copy link
Member

bjorn3 commented Jun 14, 2025

You could also add it to CI. Takes about 5min for cg_clif when only testing Linux. For handling the known test failures, there is a section in src/report.rs of abi-cafe that you can patch like so: https://github.com/rust-lang/rustc_codegen_cranelift/blob/master/patches/0002-abi-cafe-Disable-broken-tests.patch

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants