-
Notifications
You must be signed in to change notification settings - Fork 927
cargo fmt
fails with half_open_range_patterns
#4009
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Yeah I believe the underlying problem is that ATM rustfmt is using a pretty old version of the rustc internals (v610 of the rustc-ap-* crates, including the one for libsyntax). The refactoring/splitting of libsyntax over the last couple months has created some challenges in upgrading the rustc-ap-* versions within rustfmt, but I think that all of our blockers will be removed once rust-lang/rust#68135 is merged (and then gets published in rustc-ap) |
…ities, r=Centril restore some rustc_parse visibilities for rustfmt In rust-lang@c189565 some visibilities were reduced on the parse mod (which now resides in the rustc_parse crate) as part of some refactoring and splitting up of libsyntax. However, rustfmt needs access to a few of those items that are no longer visible. This restores the visibility on those items rustfmt depends on. rust-lang/rustfmt#3903 (comment) rust-lang/rustfmt#4009 cc @topecongiro
…ities, r=Centril restore some rustc_parse visibilities for rustfmt In rust-lang@c189565 some visibilities were reduced on the parse mod (which now resides in the rustc_parse crate) as part of some refactoring and splitting up of libsyntax. However, rustfmt needs access to a few of those items that are no longer visible. This restores the visibility on those items rustfmt depends on. rust-lang/rustfmt#3903 (comment) rust-lang/rustfmt#4009 cc @topecongiro
…ities, r=Centril restore some rustc_parse visibilities for rustfmt In rust-lang@c189565 some visibilities were reduced on the parse mod (which now resides in the rustc_parse crate) as part of some refactoring and splitting up of libsyntax. However, rustfmt needs access to a few of those items that are no longer visible. This restores the visibility on those items rustfmt depends on. rust-lang/rustfmt#3903 (comment) rust-lang/rustfmt#4009 cc @topecongiro
@topecongiro - |
Uh oh!
There was an error while loading. Please reload this page.
This example compiles fine with latest nightly, but
cargo fmt
fails. The failure also occurs on clippy's CI (https://travis-ci.com/rust-lang/rust-clippy/jobs/274511513).Probably we need rustup and update submodule on rust-lang/rust?
error log:
The text was updated successfully, but these errors were encountered: