Skip to content

Foreign function blocks dropped #4313

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
ayazhafiz opened this issue Jul 10, 2020 · 0 comments · Fixed by #4314
Closed

Foreign function blocks dropped #4313

ayazhafiz opened this issue Jul 10, 2020 · 0 comments · Fixed by #4314
Labels
bug Panic, non-idempotency, invalid code, etc.

Comments

@ayazhafiz
Copy link
Contributor

Describe the bug

rustfmt drops block associated with a foreign function

To Reproduce

Formatting

extern "C" {
    fn f() {
        fn g() {}
    }
}

gives

extern "C" {
    fn f();
}

Context: rust-lang/rust#74204

Expected behavior

The formatting makes the code semantically correct, but causes a loss of information. I think rustfmt should preserve the block, if it has access to it.

Meta

  • rustfmt version: 37ec56d
  • From where did you install rustfmt?: from source
  • How do you run rustfmt: binary from source
@ayazhafiz ayazhafiz added the bug Panic, non-idempotency, invalid code, etc. label Jul 10, 2020
ayazhafiz added a commit to ayazhafiz/rustfmt that referenced this issue Jul 10, 2020
@ayazhafiz
Don't drop blocks on foreign functions
3e60ac2 
A code like

```rust
extern "C" {
    fn f() {
        fn g() {}
    }
}
```

is incorrect and does not compile. Today rustfmt formats this in a way
that is correct:

```rust
extern "C" {
    fn f();
}
```

But this loses information, and doesn't have to be done because we know
the content of the block if it is present. During development I don't
think rustfmt should drop the block in this context.

Closes rust-lang#4313
@ayazhafiz ayazhafiz mentioned this issue Jul 10, 2020
Merged
@dtolnay dtolnay mentioned this issue Nov 29, 2020
Open
dtolnay pushed a commit to dtolnay-contrib/rustfmt that referenced this issue Nov 29, 2020
@ayazhafiz @dtolnay
Don't drop blocks on foreign functions
fa969fc 
A code like

```rust
extern "C" {
    fn f() {
        fn g() {}
    }
}
```

is incorrect and does not compile. Today rustfmt formats this in a way
that is correct:

```rust
extern "C" {
    fn f();
}
```

But this loses information, and doesn't have to be done because we know
the content of the block if it is present. During development I don't
think rustfmt should drop the block in this context.

Closes rust-lang#4313
calebcartwright pushed a commit that referenced this issue Nov 29, 2020
@ayazhafiz @calebcartwright
Don't drop blocks on foreign functions
3bf67c1 
A code like

```rust
extern "C" {
    fn f() {
        fn g() {}
    }
}
```

is incorrect and does not compile. Today rustfmt formats this in a way
that is correct:

```rust
extern "C" {
    fn f();
}
```

But this loses information, and doesn't have to be done because we know
the content of the block if it is present. During development I don't
think rustfmt should drop the block in this context.

Closes #4313
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Panic, non-idempotency, invalid code, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't drop blocks on foreign functions ayazhafiz/rustfmt
1 participant
@ayazhafiz