Skip to content

Support struct_field_attributes #1543

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2017
Merged

Support struct_field_attributes #1543

merged 1 commit into from
May 12, 2017

Conversation

topecongiro
Copy link
Contributor

Closes #1535.

nrc
nrc approved these changes May 12, 2017
View reviewed changes
Copy link
Member

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. I think you're able to remove the source test file, but feel free to merge this either way.

tests/source/struct-field-attributes.rs
@@ -0,0 +1,22 @@
// #1535
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the source and target files match exactly (which I think is the case here), you don't need the source file at all (we'll only do an idempotence test).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@topecongiro
Copy link
Contributor Author

I will keep the source test file in case we want to add tests in the future.

@topecongiro topecongiro merged commit 56515dd into rust-lang:master May 12, 2017
@topecongiro topecongiro deleted the field-attr branch May 23, 2018 15:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nrc nrc nrc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topecongiro @nrc