Skip to content

Fix rewrite of closures with a return type #4580

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Fix rewrite of closures with a return type #4580

merged 1 commit into from
Dec 8, 2020

Conversation

scampi
Copy link
Contributor

@scampi scampi commented Dec 7, 2020

If the closure's body fits in a line, the block is removed but it is
necessary if the closure has a return type.

Close #4577

If the closure's body fits in a line, the block is removed but it is
necessary if the closure has a return type.
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scampi scampi merged commit ace3c14 into master Dec 8, 2020
@scampi scampi deleted the issue-4577 branch December 8, 2020 09:54
@karyon
Copy link
Contributor

karyon commented Oct 25, 2021

backport done in #4605

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if/else closures with return type removes curly brackets
3 participants