-
Notifications
You must be signed in to change notification settings - Fork 933
format safety keywords on static items #6204
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
// See tracking issue for unsafe_extern_blocks | ||
// https://github.com/rust-lang/rust/issues/123743 | ||
|
||
#![feature(unsafe_extern_blocks)] | ||
|
||
safe static TEST1: i32; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure that formatting the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's keep it, since it doesn't hurt. |
||
|
||
unsafe extern "C" { | ||
safe static TEST2: i32; | ||
unsafe static TEST3: i32; | ||
static TEST4: i32; | ||
|
||
pub safe static TEST5: i32; | ||
pub unsafe static TEST6: i32; | ||
pub static TEST7: i32; | ||
|
||
safe fn test1(i: i32); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You left in a debug print, it seems.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am surprised that this did not make any of the tests fail...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same (#6210 (comment))
we'll do a postmortem of sorts to review and hopefully identify some preventative measures to prevent a recurrence