Detect MSVC 2017. Closes #1003 #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brson Error looks legit! |
This was referenced May 26, 2017
|
OK, I think I see the issue. |
|
Testing using a temporary branch of gcc-rs |
|
Oh yay! |
|
@bors r+ |
|
📌 Commit 99cbfe0 has been approved by |
bors
added a commit
that referenced
this pull request
May 26, 2017
Detect MSVC 2017. Closes #1003 Rust itself won't actually work until it is also updated. This just lets rustup install without a warning.
|
still just testing |
|
@bors r+ |
|
📌 Commit 99cbfe0 has been approved by |
bors
added a commit
that referenced
this pull request
May 26, 2017
Detect MSVC 2017. Closes #1003 Rust itself won't actually work until it is also updated. This just lets rustup install without a warning.
|
💔 Test failed - status-appveyor |
|
@bors retry Spurious. Suspicious. |
bors
added a commit
that referenced
this pull request
May 26, 2017
Detect MSVC 2017. Closes #1003 Rust itself won't actually work until it is also updated. This just lets rustup install without a warning.
|
☀️ Test successful - status-appveyor, status-travis |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust itself won't actually work until it is also updated. This just lets rustup install without a warning.