Skip to content

ci: update runners for macOS-related workflows #3681

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 23, 2024
Merged

ci: update runners for macOS-related workflows #3681

merged 2 commits into from
Feb 23, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Feb 23, 2024

The current macos-latest workflow points to macos-12, but it will point to macos-14 (which is arm64-based) very soon:

The macOS 12 runner image will remain latest until migration of the latest YAML workflow label to macOS 14 in Q2 FY24 (April – June 2024).

So it's necessary for us to migrate from macos-12 to macos-14 and/or macos-13 (which is x64-based), or we might face a failure sometime in 24Q2 due to inconsistent target triples.

In this PR, macos-13 is used for x64 builds, and macos-14 for arm64 builds (in a future update, this should be replaced with macos-latest). Also, the full test suite for the latter (aarch64-apple-darwin) has been enabled to get it ready for tier 1 promotion.

cc rust-lang/cargo#13377

PS: As usual, please ignore .github/workflows/ci.yaml when reviewing this PR.

@rami3l rami3l changed the title ci: use macos-14 for macOS-related workflows ci: update runners for macOS-related workflows Feb 23, 2024
@rami3l rami3l marked this pull request as ready for review February 23, 2024 03:31
@rami3l rami3l requested a review from djc February 23, 2024 03:32
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rami3l rami3l added this pull request to the merge queue Feb 23, 2024
Merged via the queue into master with commit 3f0213f Feb 23, 2024
@rami3l rami3l deleted the ci/macos-14 branch February 23, 2024 23:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants