Rewrite URLs with plus character for crates.io #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Compute@Edge function on Fastly now rewrites URLs that contain a plus character to a properly URL-encoded version. This ensures that clients access objects in S3 in a consistent way, and avoids any issues with Amazon S3's special handling of the plus character.
The CloudFront distribution for crates.io has been updated to rewrite URLs that contain a plus character to properly URL-encode the path. This ensures that clients access objects in S3 in a consistent way, and avoids any issues with Amazon S3's special handling of the plus character.
| @@ -45,6 +63,12 @@ resource "aws_cloudfront_distribution" "static" { | |||
| forward = "none" | |||
| } | |||
| } | |||
|
|
|||
| lambda_function_association { | |||
There was a problem hiding this comment.
Based on last ~30 days I think this would mean 339 million * $0.60/million requests - so roughly an extra ~$200/month. I think if we can switch to cloudfront functions we get 6x cheaper # ($0.10/million requests) and presumably roughly the same functionality for the redirects desired here?
There was a problem hiding this comment.
Great suggestion! I refactored the code to use a CloudFront function instead.
Instead of using AWS Lambda functions to rewrite URLs, we are using CloudFront functions which are simpler and cheaper.
jdno
added a commit
to jdno/rust-simpleinfra
that referenced
this pull request
Jul 14, 2023
See rust-lang#313 for details.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CDNs for
static.crates.ionow rewrites URLs that contain a plus character to a properly URL-encoded version. This ensures that clients access objects in S3 in a consistent way, and avoids any issues with Amazon S3's special handling of the plus character.See rust-lang/crates.io#4891 for more details.