Windows: Add support for Unix sockets #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarks
force-pushed
the
windows_unix
branch
2 times, most recently
from
20b6d40 to
1570949
Compare
Thomasdezeeuw
requested changes
Jul 24, 2021
jstarks
force-pushed
the
windows_unix
branch
2 times, most recently
from
0cdedf6 to
5db7219
Compare
|
I've finally addressed your comments and have rebased for 0.5. @Thomasdezeeuw, let me know if you'd like to see anything else. |
|
Just to clarify: if this is called on a Windows platform that doesn't support UDS, it just returns an error, right? |
|
Right, it will fail with |
Newer versions of Windows support AF_UNIX stream sockets. This change adds Windows support for the `SockAddr::unix` function and the `Domain::UNIX` constant. Since Unix sockets are now available on all tier1 platforms, this also removes `all` feature requirement from the `SockAddr::unix` function.
Thomasdezeeuw
approved these changes
Aug 18, 2022
|
Thanks @jstarks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of Windows support AF_UNIX stream sockets. This change
adds Windows support for the
SockAddr::unixfunction and theDomain::UNIXconstant.Since Unix sockets are now available on all tier1 platforms, this also
removes
allfeature requirement from theSockAddr::unixfunction.