Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump windows #94

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Bump windows #94

merged 4 commits into from
Aug 27, 2024

Conversation

djc
Copy link
Contributor

@djc djc commented Aug 26, 2024

The new release after #93 finally exposes the migration from #76 to a wider audience... but the windows-sys version used is now long out of date, leading to duplicate dependencies for windows-sys and all the windows-targets crates. Bump the range to allow more modern versions, including 0.52 (currently used by mio) and 0.59 (newest).

@djc
Copy link
Contributor Author

djc commented Aug 26, 2024

Per #93 (comment), Android was already broken in CI. Verified that -Zminimal-versions tested that windows-sys 0.52 works and that another job tested 0.59.

@nagisa nagisa merged commit f9300b7 into rust-lang:master Aug 27, 2024
131 of 143 checks passed
@djc
Copy link
Contributor Author

djc commented Aug 27, 2024

Thanks for the quick response!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants