Skip to content

Add remaining insturctions #1250

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Add remaining insturctions #1250

merged 5 commits into from
Nov 10, 2021

Conversation

SparrowLii
Copy link
Member

@SparrowLii SparrowLii commented Nov 9, 2021

This PR add vmmla vusmmla vsm4e vsm3 vrax1 vxar vsha512 vbcax veor3 neon instructions
FIXES #1233

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@SparrowLii SparrowLii force-pushed the vmmla branch 2 times, most recently from f02305b to 93c4ed0 Compare November 9, 2021 10:42
@SparrowLii SparrowLii force-pushed the vmmla branch 4 times, most recently from 5fa1cd3 to a0f68f8 Compare November 9, 2021 11:42
@SparrowLii SparrowLii changed the title [WIP]Add remaining insturctions Add remaining insturctions Nov 9, 2021

aarch64 = frint32x
link-aarch64 = frint32x._EXT_
// v8.5a is no_runtime feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be changed to frintts as discussed in #148.

@Amanieu
Copy link
Member

Amanieu commented Nov 10, 2021

I think the C tests are failing because they are using clang-12 but some of these intrinsics were only added in clang-13.

@Amanieu Amanieu merged commit c93ae0e into rust-lang:master Nov 10, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 20, 2021
Update stdarch

5 commits in 815d55c..cfba59f
2021-11-08 00:58:47 +0000 to 2021-11-19 01:29:04 +0000
- Work-around buggy Intel chips erroneously reporting BMI1/BMI2 support (rust-lang/stdarch#1249)
- complete armv8 instructions (rust-lang/stdarch#1256)
- Fix i8mm feature with bootstrap compiler. (rust-lang/stdarch#1252)
- Fix unused link_name attribute. (rust-lang/stdarch#1251)
- Add remaining insturctions (rust-lang/stdarch#1250)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The feature i8mm is not valid
3 participants