Skip to content

Split aarch64 pauth feature into paca and pacg #1259

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

adamgemmell
Copy link
Contributor

As per discussion on rust-lang/rust#86941, this is consistent with Linux and in the future there may well be environments with only one of address authentication or generic code authentication available.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Nov 26, 2021

LGTM, but the feature names in rustc also need to be adjusted since the macro also checks for cfg!(target_feature = "<name>") which is set by rustc.

@adamgemmell
Copy link
Contributor Author

Thanks, I didn't realise the two were coupled like that

@Amanieu
Copy link
Member

Amanieu commented Feb 6, 2022

This is still blocked on getting these features split on the rustc side.

@Amanieu
Copy link
Member

Amanieu commented Feb 9, 2022

This needs a rebase due to a conflict with #1239.

@bors
Copy link
Contributor

bors commented Feb 9, 2022

☔ The latest upstream changes (presumably 00aa60a) made this pull request unmergeable. Please resolve the merge conflicts.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants