-
Notifications
You must be signed in to change notification settings - Fork 296
Add Josh sync scripts #1835
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Josh sync scripts #1835
Conversation
r? @RalfJung |
Failed to set assignee to
|
I have a couple changes from the RDG version in https://github.com/rust-lang/compiler-builtins/tree/674910e0fa6f0fb2cc055f4f7051ff0eb53c7735/crates/josh-sync that might be worth picking up here. The biggest thing is dropping Also just updating the commit messages to crosslink the original ref (e.g. rust-lang/compiler-builtins@6e475af). You can figure this out from the |
My original plan was to create a separate repo that would contain the josh sync scripts, and they could be reused for all subtrees, either as a library or as a binary that could be |
Yeah, that sounds like a good idea. I'd prefer not to have to install |
This script doesn't use |
Oh, yeah, mine only needs josh+git as well (only the deps and commit messages are different). I was just thinking a "would you like to open a PR via |
If it generates the link it might as well |
Would it make sense to centralize all the sync scripts in rust-lang/rust since this is where all the repos are synced as sub-trees? |
I was thinking about that, but I'm not sure it's that useful, because both pulls and pushes are invoked from the subtree repo, not from the rust-lang/rust repo. |
Oh we don't actually need this anymore do we? Since https://github.com/rust-lang/josh-sync exists. |
Oh, I forgot to close the PR :) Anyway, I'll send another one where I document josh-sync and remove the scripts. |
This pretty much 1:1 mirrors the sync scripts of rustc-dev-guide. If you want, I can also setup a CI bot (similar to rdg or miri) that will attempt to create PRs with pull synces once every few days, and post to Zulip if there is a merge conflict.