fix errors/warnings from the stabilization of cfg_target_feature and target_feature #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r=me, thanks! |
|
i686-unknown-linux-gnu: error: failed to prepare thin LTO module: Invalid function metadata: outgoing forward refs (Producer: 'LLVM6.0.0' Reader: 'LLVM 6.0.0')
error: aborting due to previous error
error: Could not compile `coresimd`.
warning: build failed, waiting for other jobs to finish...
error: build failed
error[E0658]: the target feature `neon` is currently unstable
--> /checkout/crates/coresimd/src/../../../coresimd/arm/neon.rs:772:18
|
772 | #[target_feature(enable = "neon")]
| ^^^^^^^^^^^^^^^
|
= help: add #![feature(aarch64_target_feature)] to the crate attributes to enablebut that feature is enabled AFAICT. |
alexcrichton
force-pushed
the
fixc
branch
2 times, most recently
from
52a48e5 to
2d0fc61
Compare
|
I've asked on rust-lang/rust#49904 about the LTO error at rust-lang/rust#49904 (comment). No idea what's going on there :( |
Crap :/ I probably can't take a look at this till monday; it seems that windows on appveyor has the same problem. |
Following upstream proc_macro changes
Instead use RUSTFLAGS with `--cfg`. This'll help us be compatible with the latest Cargo where a tweak to workspaces and features made the previous invocations we had invalid.
|
In the meantime something magical seems to have happened and we're all green now! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.