ARM DSP: add quad/double add/sub + exchange and select bytes intrinsics #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsics - Quad 8-bit addition/subtraction - Double 8-bit addition/subtraction - Saturating Add and Subtract with Exchange and Saturating Subtract and Add with Exchange, signed - Select bytes based on GE bits This patch bump the `assert_instr` limit to 22 (from 20) instead of add a lots of exception for all DSP intrinsics.
gnzlbg
reviewed
Jul 21, 2018
| @@ -135,7 +232,7 @@ mod tests { | |||
| let a = i8x4::new(1, 2, 3, ::std::i8::MAX); | |||
| let b = i8x4::new(2, -1, 0, 1); | |||
| let c = i8x4::new(3, 1, 3, ::std::i8::MAX); | |||
| let r: i8x4 = ::mem::transmute(dsp::qadd8(::mem::transmute(a), ::mem::transmute(b))); | |||
| let r: i8x4 = dsp_call!(dsp::qadd8, a, b); | |||
There was a problem hiding this comment.
why is the macro being used in the tests?
There was a problem hiding this comment.
Just to cut long lines. For sure I can use ::mem::transmute, but for my understanding why is it wrong here?
|
👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the following DSP intrinsics:
Saturating Subtract and Add with Exchange, signed
This patch bump the
assert_instrlimit to 22 (from 20) instead of add a lots of exception for all DSP intrinsics.