Enable edition=2018 for core_arch #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
reviewed
Apr 18, 2019
|
@taiki-e done, let's see if updating stdsimd is enough to get core compiling with rust2018 ! |
bjorn3
reviewed
Apr 19, 2019
| use stdsimd_test::simd_test; | ||
| use test::black_box; // Used to inhibit constant-folding. | ||
| use crate::hint::black_box; | ||
| use stdsimd_test::simd_test; // Used to inhibit constant-folding. |
There was a problem hiding this comment.
Comment moved from black_box to simd_test.
| use stdsimd_test::simd_test; | ||
| use test::black_box; // Used to inhibit constant-folding. | ||
| use crate::hint::black_box; | ||
| use stdsimd_test::simd_test; // Used to inhibit constant-folding. |
| use std::f32::NAN; | ||
| use stdsimd_test::simd_test; | ||
| use test::black_box; // Used to inhibit constant-folding. | ||
| use stdsimd_test::simd_test; // Used to inhibit constant-folding. |
| use crate::core_arch::{simd::*, x86::*}; | ||
| use stdsimd_test::simd_test; | ||
| use test::black_box; // Used to inhibit constant-folding. | ||
| use stdsimd_test::simd_test; // Used to inhibit constant-folding. |
|
@bjorn3 thanks, the comments should probably just be deleted. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets core_arch to the 2018 edition, meaning that rust-lang/rust cannot be updated until rust-lang/rust#58702 is merged. cc @taiki-e