[breaking change] fix return type of _rdtsc #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to merge this, and update stdsimd upstream, doing a crater run. |
gnzlbg
added a commit
to gnzlbg/rust
that referenced
this pull request
Apr 22, 2019
This commit updates stdsimd and contains two breaking changes: * rust-lang/stdarch#733 * rust-lang/stdarch#586 We already did a crater run of 586 but we should do another one here.
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 25, 2019
Breaking update of stdsimd This commit updates stdsimd and contains two breaking changes: * rust-lang/stdarch#733 * rust-lang/stdarch#586 We already did a crater run of 586 but we should do another one here. r? @alexcrichton
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #559 .
The bug was reported to Intel (see #559), they haven't answered yet AFAICT, GCC does fix the bug, and so should we. We should do a crater run, and see if the fix is possible. Hopefully most people are just calling the intrinsic followed by
as u64anyways to workaround this. We'll see.