Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Automatically fixup linked issues in subtree repository #1897

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Feb 4, 2025

This PR adds a new handler to "relink" linked GitHub issues into their unambiguous form so that when pulling commits from a subtree into the main repository we don't accidentally closes issues in the wrong repository.

Example: Fixes #123 (in rust-lang/clippy) would be automatically changed to Fixes rust-lang/clippy#123

r? @ehuss

@Urgau Urgau force-pushed the relink-handler branch 2 times, most recently from 21ac445 to 54f8126 Compare February 4, 2025 21:20
@jackh726
Copy link
Member

I think we should gate this behind a manual command to do the relinking, in case there are issues we don't wreck everyone's PR descriptions.

@Urgau
Copy link
Member Author

Urgau commented Feb 14, 2025

It's already gated behind the [relink] config, if there are any issue (which is very unlikely IMO) the relink can be disabled by removing the section from the configuration file.

Putting the relink behind a manual command renders (IMO) this handler/pass useless, as I don't think anyone is going to use it and the situation is going to stay the same without any improvements.

If we are worried about edge-cases we might miss, we can do a slow deployment, starting with lower traffic repos, and go higher trafic repo as we have more confidence in it.

@jackh726
Copy link
Member

Hmm, I suppose it's fine to land this without a gate if we start with a slow repo and allow plenty of testing time

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants