Skip to content

Do not perform PR assignment for draft PRs without r? #1963

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Apr 30, 2025

This PR changes the assignment logic to be less eager.

This is what happens after this PR:

  • When a PR is opened normally, assignment is performed.
  • When a PR is opened as a draft with r? in PR body, assignment is performed.
  • When a PR is opened as a draft without r? OR with r? ghost in PR body, assignment is not performed (it is delayed).
  • When a PR is converted from draft and there are no current assignees, assignment is performed.

Fixes: #1962

@Kobzol Kobzol requested a review from Urgau April 30, 2025 12:25
Copy link
Member

@Urgau Urgau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with or without the nits

@Kobzol Kobzol force-pushed the no-assign-on-draft branch from d8417be to 94a3146 Compare April 30, 2025 18:15
@Kobzol
Copy link
Contributor Author

Kobzol commented Apr 30, 2025

I will leave this open for a few days to see if there are any concerns. If not, I'll merge it then.

@Kobzol Kobzol added this pull request to the merge queue May 5, 2025
Merged via the queue into rust-lang:master with commit bbdda31 May 5, 2025
3 checks passed
@Kobzol Kobzol deleted the no-assign-on-draft branch May 5, 2025 12:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delay reviewer assignment for draft PRs
2 participants