Skip to content

Handle r? as assignment #433

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Handle r? as assignment #433

wants to merge 1 commit into from

Conversation

Mark-Simulacrum
Copy link
Member

This adds parsing support for handling r? to direct assignment; anyone can do so
on a PR to any org member.

A future commit will add support for r? with a team.

This does not currently auto-assign reviewers like highfive to new PRs, though.

@Mark-Simulacrum
Handle r? as assignment
bf4c6e7 
This adds parsing support for handling r? to direct assignment; anyone can do so
on a PR to any org member.

A future commit will add support for r? with a team.

This does not currently auto-assign reviewers like highfive to new PRs, though.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Mar 30, 2020
Open
pietroalbini
pietroalbini reviewed Mar 31, 2020
View reviewed changes
parser/src/command.rs
},
));
} else {
log::trace!("{:?} had non-one mention: {:?}", w, mentions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be useful to allow more than a person to be assigned: occasionally I write r? @foo @bar and manually assign @bar once highfive assigns @foo. Highfive was written before GitHub allowed multiple assignees, so I guess that's the reason why highfive didn't support that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I largely agree, though I think it is pretty useful to have just one person assigned at a time -- then there's less "well they'll do it" :)

But I don't want to try to make things better before we make things work; migrating things to triagebot is the first priority, and then once that's done we can enhance.

@pietroalbini
Copy link
Member

Other than that comment this PR looks good!

This was referenced Mar 31, 2020
Merged
Merged
Closed
Merged
Merged
Merged
Merged
bors added a commit to rust-lang/cargo that referenced this pull request Mar 31, 2020
@bors
Auto merge of #8059 - Mark-Simulacrum:add-triagebot, r=alexcrichton
c75216f 
Add triagebot configuration

This enables assignment through triagebot on this repository, in preparation for
the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433
This was referenced Mar 31, 2020
Merged
Merged
Merged
Merged
Merged
This was referenced Apr 13, 2020
Merged
Closed
Merged
Merged
bors bot added a commit to rust-embedded/embedded-alloc that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #30
a4f8788 
30: Add triagebot configuration r=jonas-schievink a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
@LeSeulArtichaut LeSeulArtichaut mentioned this pull request Apr 13, 2020
Merged
bors bot added a commit to rust-embedded/bare-metal that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #30
74881d6 
30: Add triagebot configuration r=jonas-schievink a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
This was referenced Apr 13, 2020
Merged
Merged
Closed
Merged
Merged
Merged
bors bot added a commit to rust-embedded/not-yet-awesome-embedded-rust that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #18
c9de905 
18: Add triagebot configuration r=adamgreig a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/awesome-embedded-rust that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #263
26218b9 
263: Add triagebot configuration r=adamgreig a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/cortex-m-rt that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #263
5dbbcde 
263: Add triagebot configuration r=jonas-schievink a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/svd2rust that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #435
23e3b0a 
435: Add triagebot configuration r=therealprof a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/svd that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #110
608088c 
110: Add triagebot configuration r=therealprof a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/linux-embedded-hal that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #40
734f41e 
40: Add triagebot configuration r=posborne a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/rust-sysfs-gpio that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #63
e220e63 
63: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/rust-i2cdev that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #61
6925d34 
61: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/embedded-hal that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #202
181d44b 
202: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/rust-spidev that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #23
deb29ab 
23: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/rust-sysfs-pwm that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #11
1acd9c7 
11: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/svd2rust that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #435
d2ee11a 
435: Add triagebot configuration r=therealprof a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/showcase that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #22
98337d1 
22: Add triagebot configuration r=therealprof a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/blog that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #119
80f8b87 
119: Add triagebot configuration r=therealprof a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/itm that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #28
5fec2b3 
28: Add triagebot configuration r=therealprof a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to cross-rs/cross that referenced this pull request Apr 13, 2020
@bors @LeSeulArtichaut
Merge #408
2ddc30f 
408: Add triagebot configuration r=Dylan-DPC a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/gpio-utils that referenced this pull request Apr 14, 2020
@bors @LeSeulArtichaut
Merge #30
02f92d5 
30: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/embedonomicon that referenced this pull request Apr 14, 2020
@bors @LeSeulArtichaut
Merge #65
35b9588 
65: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/rust-embedded.github.io that referenced this pull request Apr 14, 2020
@bors @LeSeulArtichaut
Merge #22
40eacce 
22: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/discovery that referenced this pull request Apr 14, 2020
@bors @LeSeulArtichaut
Merge #223
1611e93 
223: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/svd2rust that referenced this pull request Apr 22, 2020
@bors @LeSeulArtichaut
Merge #435
afb96f7 
435: Add triagebot configuration r=therealprof a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
bors bot added a commit to rust-embedded/rust-embedded.github.io that referenced this pull request Jul 4, 2020
@bors @LeSeulArtichaut
Merge #22
7e9708c 
22: Add triagebot configuration r=ryankurte a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
@kellda
Copy link
Contributor

kellda commented Jul 9, 2020 •
edited
Loading

Rebased on master at https://github.com/kellda/triagebot/tree/highfive-review
Need to be rebased / rewritten

bors bot added a commit to rust-embedded/itm that referenced this pull request Jul 25, 2020
@bors @LeSeulArtichaut
Merge #28
e6e1309 
28: Add triagebot configuration r=jonas-schievink a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
@kellda kellda mentioned this pull request Oct 29, 2020
Closed
@LeSeulArtichaut LeSeulArtichaut mentioned this pull request Nov 23, 2020
Merged
@camelid camelid mentioned this pull request Mar 20, 2021
Merged
adamgreig pushed a commit to rust-embedded/cortex-m that referenced this pull request Jan 12, 2022
@bors @LeSeulArtichaut
Merge #263
70c8edf 
263: Add triagebot configuration r=jonas-schievink a=LeSeulArtichaut

This enables [assignment](https://github.com/rust-lang/triagebot/wiki/Assignment) through triagebot on this repository, in preparation for the migration from highfive to triagebot for PR assignment.

cc rust-lang/highfive#258 rust-lang/triagebot#433

Co-authored-by: LeSeulArtichaut <leseulartichaut@gmail.com>
@fmease
Copy link
Member

fmease commented Nov 3, 2022

This can be closed since the functionality is now implemented, right?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pietroalbini pietroalbini pietroalbini left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mark-Simulacrum @pietroalbini @kellda @fmease