fix: prevent menus from being created after windows #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoraCodes
added
c-bug
NoraCodes
force-pushed
the
nora/fix-menu-unsafety
branch
from
4fb4c72 to
fdbb6f3
Compare
|
@LoganDark am I correct in thinking you have access to a Mac? As this is the last blocker to 0.4, would you be willing to do a quick test of this branch? It works OK for me on Linux but I can't test Darwin. |
|
@NoraCodes It's actually much better than that, I have access to a Mac that triple boots macOS, Windows and Linux. Anyway, sure, I'd be willing to test this out. In the meantime would you mind providing a test case for the specific behavior you're trying to fix? I can do my testing as well of course but just making sure. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40
Ideally we will eventually get a better API for this