-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use lapack-sys crate directly from lax crate #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 89.90% 90.06% +0.15%
==========================================
Files 71 71
Lines 3756 3864 +108
==========================================
+ Hits 3377 3480 +103
- Misses 379 384 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
termoshtt
force-pushed
the
use-lapack-sys-directly
branch
from
August 31, 2022 07:03
e890abf
to
328abd3
Compare
termoshtt
changed the title
Use lapack-sys crate directly
Use lapack-sys crate directly from lax crate
Aug 31, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step of #327.
The problem of
lapack
crate is it requires slice&[T]
which must be initialized while the pointer-based API inlapack-sys
does not.