Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use lapack-sys crate directly from lax crate #328

Merged
merged 21 commits into from
Aug 31, 2022
Merged

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Aug 31, 2022

First step of #327.

The problem of lapack crate is it requires slice &[T] which must be initialized while the pointer-based API in lapack-sys does not.

@termoshtt termoshtt added the change Compatible change label Aug 31, 2022
@termoshtt termoshtt self-assigned this Aug 31, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #328 (2fc0ac8) into master (0cfde73) will increase coverage by 0.15%.
The diff coverage is 96.74%.

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   89.90%   90.06%   +0.15%     
==========================================
  Files          71       71              
  Lines        3756     3864     +108     
==========================================
+ Hits         3377     3480     +103     
- Misses        379      384       +5     
Impacted Files Coverage Δ
lax/src/solveh.rs 75.00% <72.00%> (-3.79%) ⬇️
lax/src/eigh.rs 94.82% <91.17%> (+0.59%) ⬆️
lax/src/cholesky.rs 100.00% <100.00%> (ø)
lax/src/eig.rs 100.00% <100.00%> (ø)
lax/src/least_squares.rs 100.00% <100.00%> (ø)
lax/src/lib.rs 96.55% <100.00%> (+4.24%) ⬆️
lax/src/opnorm.rs 100.00% <100.00%> (ø)
lax/src/qr.rs 100.00% <100.00%> (ø)
lax/src/rcond.rs 100.00% <100.00%> (ø)
lax/src/solve.rs 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@termoshtt termoshtt changed the title Use lapack-sys crate directly Use lapack-sys crate directly from lax crate Aug 31, 2022
@termoshtt termoshtt marked this pull request as ready for review August 31, 2022 12:15
@termoshtt termoshtt merged commit 791713f into master Aug 31, 2022
@termoshtt termoshtt deleted the use-lapack-sys-directly branch August 31, 2022 12:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
change Compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant