Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revise enum namings #331

Merged
merged 8 commits into from
Sep 3, 2022
Merged

Revise enum namings #331

merged 8 commits into from
Sep 3, 2022

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Sep 2, 2022

Old New
UVTFlag JobSvd
UVTFlag::Full JobSvd::All
FlagSVD JobSvd (integrated)
EigenVectorFlag JobEv
EigenVectorFlag::Calc JobEv::All
EigenVectorFlag::Not JobEv::None
  • These definitions are moved into lax::flags submodule
  • Note that JobSvd is also exposed in ndarray-linalg crate

@termoshtt termoshtt added the breaking change Non-compatible change label Sep 2, 2022
@termoshtt termoshtt self-assigned this Sep 2, 2022
@termoshtt termoshtt changed the title Revise enum namings Revise enum namings in lax Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #331 (86c61c3) into master (08aae3b) will decrease coverage by 0.04%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
- Coverage   89.97%   89.92%   -0.05%     
==========================================
  Files          71       72       +1     
  Lines        3911     3912       +1     
==========================================
- Hits         3519     3518       -1     
- Misses        392      394       +2     
Impacted Files Coverage Δ
lax/src/lib.rs 90.90% <ø> (-5.97%) ⬇️
lax/src/triangular.rs 100.00% <ø> (ø)
lax/src/svd.rs 96.07% <80.00%> (-3.93%) ⬇️
ndarray-linalg/tests/svddc.rs 94.87% <90.00%> (ø)
lax/src/eig.rs 100.00% <100.00%> (ø)
lax/src/eigh.rs 95.00% <100.00%> (ø)
lax/src/flags.rs 100.00% <100.00%> (ø)
lax/src/svddc.rs 100.00% <100.00%> (ø)
ndarray-linalg/src/svddc.rs 90.47% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@termoshtt termoshtt changed the title Revise enum namings in lax Revise enum namings Sep 3, 2022
@termoshtt termoshtt marked this pull request as ready for review September 3, 2022 06:38
@termoshtt termoshtt merged commit a4b3118 into master Sep 3, 2022
@termoshtt termoshtt deleted the revise-flag-naming branch September 3, 2022 06:39
termoshtt added a commit that referenced this pull request Sep 16, 2022
matthagan15 pushed a commit to matthagan15/ndarray-linalg that referenced this pull request Mar 3, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
breaking change Non-compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant