Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merge Solve_, Solveh_ and Cholesky_ into Lapack trait #346

Merged
merged 15 commits into from
Oct 1, 2022

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Sep 29, 2022

For #168, Same as #340, #341, #343, and #345

  • Merge Solve_ into Lapack trait
    • Add InvWork struct
  • Merge Solveh_ into Lapack trait
    • Add BkWork struct
  • Merge Cholesky_ into Lapack trait

@termoshtt termoshtt added the breaking change Non-compatible change label Sep 29, 2022
@termoshtt termoshtt self-assigned this Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #346 (7e61539) into master (07ab31d) will decrease coverage by 0.06%.
The diff coverage is 85.33%.

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   90.05%   89.98%   -0.07%     
==========================================
  Files          74       74              
  Lines        4525     4555      +30     
==========================================
+ Hits         4075     4099      +24     
- Misses        450      456       +6     
Impacted Files Coverage Δ
lax/src/cholesky.rs 100.00% <ø> (ø)
lax/src/solveh.rs 73.21% <72.41%> (-2.30%) ⬇️
lax/src/lib.rs 94.64% <86.36%> (-5.36%) ⬇️
lax/src/solve.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@termoshtt termoshtt marked this pull request as ready for review October 1, 2022 06:46
@termoshtt termoshtt merged commit acd7858 into master Oct 1, 2022
@termoshtt termoshtt deleted the lax-solve-impl branch October 1, 2022 07:35
@termoshtt termoshtt added new feature and removed breaking change Non-compatible change labels Oct 3, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant