Add .into_raw_vec_with_offset() and deprecate .into_raw_vec() #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the offset from start of allocation to the logically first element of the array, correctly reinterpreting the results of .into_raw_vec() as an n-D array is tricky.
bluss
changed the title
adamreichold
reviewed
Apr 2, 2024
adamreichold
reviewed
Apr 2, 2024
adamreichold
reviewed
Apr 2, 2024
adamreichold
reviewed
Apr 2, 2024
Provide a smoother transition by deprecating the old method and introducing a new one. Return Option<usize>, this makes the empty vector case stand out as a separate case that needs to be handled.
adamreichold
approved these changes
Apr 4, 2024
|
thanks for looking at this |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the offset from start of allocation to the logically first element of the array,
correctly reinterpreting the results of .into_raw_vec() as an n-D array is tricky.
Provide a smoother transition by deprecating the old method and
introducing a new one.
Return Option, this makes the empty vector case stand out
as a separate case that needs to be handled.
Closes #994 by superseding it.