Add flatten, flatten_with_order and into_flat to arrays
#1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluss
requested changes
Jul 9, 2024
barakugav
force-pushed
the
flatten
branch
2 times, most recently
from
342f1f3
to
692fae5
Compare
bluss
reviewed
Jul 12, 2024
bluss
reviewed
Jul 12, 2024
bluss
approved these changes
Jul 21, 2024
|
Maintainer pushed to fix to always use into_shape_clone (it only clones when necessary) |
|
clippy lints we'll fix in another PR |
|
Can now be rebased on master because clippy errors are fixed there. |
bluss
changed the title
flatten, flatten_with_order and into_flat to arrays
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.