-
Notifications
You must be signed in to change notification settings - Fork 320
Added basic implementation of windows iterators #306
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Thanks, it looks good.
Good tests so it looks good. The whole ndproducer thing has really taken off since we started discussing this, so there hasn't been a clear goal to work towards, shifting all the time :D Now that we have an Indices ndproducer we know that we can in theory produce anything we want as an ndproducer (including the ragged edges chunks, if we need that). |
Thanks for the fast feedback. Should be fixed now. :) Since I haven't that much time at the moment I'd be happy if you take over the implementation of the NdProducer thingy for the
I think I haven't yet fully understood the |
Thanks! the ndarray tests themselves pass, so we can merge. |
use IntoDimension; | ||
|
||
pub struct Windows<'a, A: 'a, D> { | ||
iter : ::iter::Iter<'a, A, D>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alignment like this, it's a minor issue. I see what it's trying to do, but I prefer to keep this consistent and not do this. Such small things can always be fixed up afterwards, so I try to not focus on them. But it's good to mention, for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay good to know. I just made it out of habit as I try to simply stick to the project's conventions. :)
I wish one day we can automate this formatting.^^
Quick plug: #rust-sci is a new irc channel we are trying to start and get going. One more rust channel! |
I guess "sci" simply stands for "science"? |
We wanted it to be everything about numeric and scientific stuff in Rust |
Features:
Windows
struct based onBaseIter
fn windows
used internally, similar tofn exact_chunks
fn windows(&self, ...)
fora.windows(Dim(...))
usageAddresses issue #276.