Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update ndarray to Rust 2018 edition #567

Merged
merged 1 commit into from
Dec 11, 2018

Conversation

jturner314
Copy link
Member

@jturner314 jturner314 commented Dec 6, 2018

Most of the changes are adding a crate prefix to use statements and changing try! to ?. I also renamed libnum to num_traits because cargo fix was wanting to add a crate prefix, e.g. use crate::libnum::Whatever, and I didn't see any reason for the num-traits crate to be renamed to libnum anyway.

This PR changes only the ndarray crate; it doesn't change the ndarray-rand crate.

Edit: Also note that I've just run cargo fix --edition and made some manual improvements. I haven't run cargo fix --edition-idioms, because according to the docs, --edition-idioms isn't ready yet.

Copy link
Member

@bluss bluss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy with the new path rules so far. Rust 2018 ftw

@jturner314 jturner314 merged commit 27c84a5 into rust-ndarray:master Dec 11, 2018
@jturner314 jturner314 deleted the rust-2018 branch December 11, 2018 01:19
@hellow554
Copy link

hellow554 commented Dec 19, 2018

Is there a 0.13 planned for the edition bumb? Or do you still want to push it as 0.12.1?

@bluss
Copy link
Member

bluss commented Dec 19, 2018

Several breaking changes merged and coming, so it's a bump

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants