Update ndarray to Rust 2018 edition #567
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the changes are adding a
crate
prefix touse
statements and changingtry!
to?
. I also renamedlibnum
tonum_traits
becausecargo fix
was wanting to add acrate
prefix, e.g.use crate::libnum::Whatever
, and I didn't see any reason for thenum-traits
crate to be renamed tolibnum
anyway.This PR changes only the
ndarray
crate; it doesn't change thendarray-rand
crate.Edit: Also note that I've just run
cargo fix --edition
and made some manual improvements. I haven't runcargo fix --edition-idioms
, because according to the docs,--edition-idioms
isn't ready yet.