Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Changes for protocol version 1 #5

Closed
wants to merge 3 commits into from
Closed

Conversation

hoytech
Copy link
Contributor

@hoytech hoytech commented Dec 7, 2023

Hi Yuki!

I have made some pretty major changes to the negentropy protocol, which is now "version 1" (previous was version 0).

I made the updates to your Rust implementation that bring it to parity with the C++ and JS implementations.

I'm going to be releasing a strfry instance that supports syncing with protocol version 1 very soon.

Happy to answer any questions, and please forgive any Rust-related issues since I'm not very experienced in this language.

I have not yet tested any of the bindings to other languages.

Cheers,
Doug

@yukibtc
Copy link
Member

yukibtc commented Dec 7, 2023

Hi Doug, thanks for the update!

I made some cleanups and fixes in PR #6. Can you confirm that harness test pass?

If you are interested to test bindings (for now I packaged only python, I hope to package also Kotlin, Swift and Ruby soon) these are the steps:

  • cd negentropy-ffi
  • make python (the command look for .so linux shared library, if you are on mac or windows needs changes)
  • python bindings-python/examples/client.py

@hoytech
Copy link
Contributor Author

hoytech commented Dec 13, 2023

Thanks! There was a small issue surfaced by the harness tests, I've opened PR #7 to fix that.

I will try to find some time to look at the Python bindings soon.

@hoytech hoytech closed this Dec 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants