Skip to content

Consider all other exit codes besides 'test-success-exit-code' as failures #65

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Aug 3, 2020

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented Jul 29, 2020

  • add test-no-reboot config key (defaults to true) to pass -no-reboot for test executables
  • add a test that intentionally triggers a reboot/triple fault
  • fix the check for exit-code 0

Closes #61

Edit (phil-opp): This is a breaking change.

@Freax13
Copy link
Member Author

Freax13 commented Jul 29, 2020

ci failing is probably not due to the changes:

error: failed to read `/usr/share/rust/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libstd/Cargo.toml`

on an unrelated test.

Someone else also just posted this error on stackoverflow: https://stackoverflow.com/questions/63151602/rust-process-failed-with-exit-code-101-using-github-actions

@phil-opp
Copy link
Member

Thanks for the pull request! I'm currently a bit busy, but I'll try to review this as soon as possible.

The CI changes are caused by a cargo bug in the latest nightly: rust-lang/cargo#8557. It was caused by the directory layout changes in rust-lang/rust#73265.

Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot!

@phil-opp phil-opp merged commit cc3a364 into rust-osdev:master Aug 3, 2020
@phil-opp
Copy link
Member

phil-opp commented Aug 3, 2020

Published as v0.10.0

phil-opp added a commit that referenced this pull request Aug 3, 2020
@0xethsign
Copy link

0xethsign commented Mar 6, 2021

Hey, I have the same error
thread 'test_middleware' panicked at 'requires the `rt` Tokio feature flag', /home/runner/.cargo/registry/src/github.heygears.com-1ecc6299db9ec823/tokio-1.2.0/src/blocking.rs:18:9

The ci build is failing on github actions. What is the fix?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider all other exit codes besides 'test-success-exit-code' as failures
3 participants