Skip to content

[Fixed] Bootloader v0.9.17 seems to be broken on Rust nightly-2021-05-20 #167

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
phil-opp opened this issue May 20, 2021 · 5 comments
Closed
Labels
nightly-breakage Code is broken on the latest Rust nightly

Comments

@phil-opp
Copy link
Member

I just noticed this in the automated CI runs for the blog_os project: https://github.com/phil-opp/blog_os/runs/2626134888?check_suite_focus=true#step:12:47

When trying to run cargo +nightly-2021-05-20 run, the following error occurs:

image

The error message is "Failed to load rest of bootloader" and happens in the early assembly stages.

I'm not sure what's going wrong yet, I will update this issue when I find the cause.

@phil-opp phil-opp added the nightly-breakage Code is broken on the latest Rust nightly label May 20, 2021
@phil-opp phil-opp pinned this issue May 20, 2021
@phil-opp phil-opp changed the title Bootloader v0.9.17 seems to be broken on nightly-2021-05-20 Bootloader v0.9.17 seems to be broken on Rust nightly-2021-05-20 May 20, 2021
@phil-opp
Copy link
Member Author

Diff between the working and broken nightly: rust-lang/rust@4e3e6db...f94942d

@bjorn3
Copy link
Contributor

bjorn3 commented May 20, 2021

--gc-sections is now only passed if "linker-is-gnu": true is used inside the target spec (rust-lang/rust#85274). The blog os target spec doesn't mention it. Maybe the first stage is too big without --gc-sections?

@phil-opp
Copy link
Member Author

@bjorn3 Ah thanks, I think that's likely the reason. I'll push a fix in a moment.

@phil-opp
Copy link
Member Author

I opened #168 with a fix.

@phil-opp phil-opp changed the title Bootloader v0.9.17 seems to be broken on Rust nightly-2021-05-20 [Fixed] Bootloader v0.9.17 seems to be broken on Rust nightly-2021-05-20 May 20, 2021
@phil-opp
Copy link
Member Author

Fix published as v0.9.18. A cargo update -p bootloader should be enough to fix this issue in downstream crates.

phil-opp added a commit that referenced this issue May 21, 2021
It was previously added automatically by Rust. See #167 for more info.
@phil-opp phil-opp unpinned this issue Aug 7, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
nightly-breakage Code is broken on the latest Rust nightly
Projects
None yet
Development

No branches or pull requests

2 participants