-
Notifications
You must be signed in to change notification settings - Fork 215
Use new inline assembly syntax for the 0.9 series #204
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
It currently happens to work fine using cg_llvm as the global_asm!() ends up in the same cgu as the use of this global. There is no guarantee that this will always be the case and in fact in case of cg_clif this happens to not be the case, thus causing a linker error.
4868874
to
4057db1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Published as v0.9.21 |
Would it be possible to push v0.9.21 to crates.io? Many thanks. |
@SlyMarbo Sorry, I forgot to do the actual |
Amazing! Thanks for all your hard work. It's really appreciated. |
No description provided.