Skip to content

Use new inline assembly syntax for the 0.9 series #204

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Jan 9, 2022

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Nov 24, 2021

No description provided.

It currently happens to work fine using cg_llvm as the global_asm!()
ends up in the same cgu as the use of this global. There is no guarantee
that this will always be the case and in fact in case of cg_clif this
happens to not be the case, thus causing a linker error.
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@phil-opp
Copy link
Member

phil-opp commented Jan 9, 2022

Published as v0.9.21

phil-opp added a commit that referenced this pull request Jan 9, 2022
@bjorn3 bjorn3 deleted the new_asm_for_0_9 branch January 9, 2022 15:34
@SlyMarbo
Copy link

Would it be possible to push v0.9.21 to crates.io? Many thanks.

@phil-opp
Copy link
Member

@SlyMarbo Sorry, I forgot to do the actual cargo publish. Thanks for reminding me, done!

@SlyMarbo
Copy link

Amazing! Thanks for all your hard work. It's really appreciated.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants