Skip to content

add UEFI PXE support #237

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 6 commits into from
Jun 6, 2022
Merged

add UEFI PXE support #237

merged 6 commits into from
Jun 6, 2022

Conversation

Freax13
Copy link
Member

@Freax13 Freax13 commented May 10, 2022

This pr implements a UEFI PXE bootloader by extending the existing UEFI bootloader to load a kernel from a TFTP server if the DevicePath of the LoadedImage has a device implementing PXE BaseCode protocol.

This pr needs some unreleased new features of the uefi-rs crate, so we'll have to wait for a new release before merging this branch (I switched the uefi-rs dependency to use the master branch for now). This is the reason I'm marking the pr as a draft.

Related to #87

@phil-opp
Copy link
Member

Thanks a lot for the PR, looks good overall! I'm happy to merge it once you think it's ready, just let me know.

@Freax13
Copy link
Member Author

Freax13 commented May 26, 2022

Thanks a lot for the PR, looks good overall! I'm happy to merge it once you think it's ready, just let me know.

I'll add some more comments, but after that it should be done

@Freax13 Freax13 marked this pull request as ready for review May 26, 2022 14:45
@Freax13
Copy link
Member Author

Freax13 commented May 26, 2022

Thanks a lot for the PR, looks good overall! I'm happy to merge it once you think it's ready, just let me know.

It's ready now! 🎉

Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left two minor annotations, then we can merge.

Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
@phil-opp phil-opp merged commit 47256d8 into rust-osdev:next Jun 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants