use panic_implementation instead of panic_fmt #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change was merged in rust-lang/rust#50338.
|
I try to keep up with nightlies, but I'm not always able to fix build issues daily. Thanks for the pull request, though! Looks good. |
|
Not a problem at all! I definitely got blindsided by this one. |
|
Also sorry about that compile error, I totally thought I tested with the new message change but I must've forgot. I just found it myself. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change was merged in rust-lang/rust#50338. I don't know how regularly you expect users to update to the lastest nightly, but I just updated last night and got this change, and this fixes it for me. I built it with this change and ran the test harness and it all seemed to work.