wasm: Depend on wasm-bindgen 0.2.89 or higher #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasm-bindgen 0.2.62 is not compatible with a wasm ABI change that rustc wishes to enable by default for wasm32-unknown-unknown, currently gated behind passing the -Zwasm-c-abi flag to rustc. wasm-bindgen 0.2.89 should exhibit seamless behavior before and after the ABI change to match the C ABI, so depend on that.
workingjubilee
force-pushed
the
dep-wasm-bindgen-0.2.89
branch
from
9355ef3 to
8c447ca
Compare
newpavlov
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
I don't think this change will have any meaningful impact. Dependency versions are selected by downstream users, so if they keep an up-to-date version of getradom, they are likely using the latest version of wasm-bindgen as well. But I guess it's fine to merge this PR to future-proof ourselves.
|
ime it's not uncommon (or at least, I do it) to bump things more selectively in one's direct dependencies and allowing cascades. but yeah it's possible this has no effect, it's partly an experiment to see if it does. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm-bindgen 0.2.62 is not compatible with a wasm ABI change that rustc wishes to enable by default for wasm32-unknown-unknown, currently gated behind passing the -Zwasm-c-abi flag to rustc.
wasm-bindgen 0.2.89 should exhibit seamless behavior before and after the ABI change to match the C ABI, so depend on that.
For more information, see
wasm_c_abifuture-incompatlint rust-lang/rust#117918wasm-c-abiflag rust-lang/rust#122532