Replace SeedableRng impl for SmallRng with inherent fns #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests failed because Additional change: make Aside: if we could bring |
newpavlov
approved these changes
Dec 31, 2023
This was referenced Nov 20, 2024
benjamin-lieser
pushed a commit
to benjamin-lieser/rand
that referenced
this pull request
Feb 5, 2025
…1368) * Simplify redundant doc-link * Remove impl of SeedableRng for SmallRng * Fix SeedableRng::Seed type for StdRng * SmallRng: do not expect thread_rng * Make SmallRng::from_thread_rng infallible * Fix benchmarks (SmallRng does not have from_entropy)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1285 by:
SeedableRngimpl forSmallRng. Use inherent fns instead.Seedtype forStdRng(the only practical effect is to make a possible future breaking change to the API more obvious).Loss of functionality:
SmallRngcan no longer be used in generics requiring aSeedableRngbound. As such, it can also no longer be reseeded from generic code. Is this an issue?SmallRng::from_seedfunction. This is deliberate since most useful uses require a portable RNG.