-
-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cleaner README, remove MSRV shields #1417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it makes sense to share the version
field. A minor change in, say, rand
will not warrant new releases of other crates.
MSRV of crates also may evolve differently (e.g. adding new SIMD backends to rand_chacha
may bump its MSRV), especially considering that in future we will get MSRV-aware resolver and thus will be able to bump MSRV "backward compatibly".
On a somewhat relevant note: it may be worth to consider moving |
I take the view that if it isn't tested, it doesn't work, and we only have one CI test for MSRV. We've been using a common policy across this repo for a while already. I suspect |
It's matter of bumping MSRV in future, e.g. why should MSRV bump for Also, I don't think that this: edition.workspace = true
rust-version.workspace = true is cleaner than this: edition = "2021"
rust-version = "1.61" Yes, it helps with bumping MSRV/edition, but we do it quite rarely, while user often look into Cargo.toml for information about crate and such indirection only wastes their time. |
It doesn't prevent that.
No. The only advantage is making those values easier to change. Bevy have a cleaner set-up, but I couldn't find doc on how it works and Either way, this stuff isn't very important. |
I don't think so, older Rust versions will just ignore I agree makes sense to have the same MSRV for all crates if that is what we are testing. If the MSRVs diverge, it should be reflected by the CI, and we can still change that later. |
Workspace inheritance was only stabilised in 1.64 so we can't do that yet.
Done.
No (at least not since versions which support
|
rust-version
prevents older rust versions from attempting to compile the code-base.This reduces the MSRV to one place: the top
Cargo.toml
.